Skip to content

Conversation

Urgau
Copy link
Member

@Urgau Urgau commented Jun 7, 2025

Fixes #142150
r? bootstrap

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 7, 2025
@rust-log-analyzer

This comment has been minimized.

@Urgau Urgau force-pushed the check-cfg-bootstrap-only-rustc branch from d2e1a2f to 9897067 Compare June 7, 2025 13:11
@rust-log-analyzer

This comment has been minimized.

@Urgau Urgau force-pushed the check-cfg-bootstrap-only-rustc branch from 9897067 to 1d5e645 Compare June 7, 2025 13:51
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@Urgau Urgau force-pushed the check-cfg-bootstrap-only-rustc branch from 79794e5 to 9b1cd72 Compare June 7, 2025 16:11
@Kobzol
Copy link
Member

Kobzol commented Jun 9, 2025

Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 9, 2025

📌 Commit 9b1cd72 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 9, 2025
bors added a commit that referenced this pull request Jun 9, 2025
Rollup of 6 pull requests

Successful merges:

 - #141751 (Remap compiler vs non-compiler sources differently (bootstrap side))
 - #142160 (Only allow `bootstrap` cfg in rustc & related)
 - #142191 (early return in trait detection for non-trait item)
 - #142211 (Do not checkout GCC submodule for the tidy job)
 - #142218 (CI: rfl: move job forward to Linux v6.16-rc1)
 - #142224 (Avoid a gratuitous 10s wait in a stress test)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ad378be into rust-lang:master Jun 9, 2025
10 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 9, 2025
rust-timer added a commit that referenced this pull request Jun 9, 2025
Rollup merge of #142160 - Urgau:check-cfg-bootstrap-only-rustc, r=Kobzol

Only allow `bootstrap` cfg in rustc & related

Fixes #142150
r? bootstrap
tautschnig pushed a commit to model-checking/verify-rust-std that referenced this pull request Jun 17, 2025
…tc, r=Kobzol

Only allow `bootstrap` cfg in rustc & related

Fixes rust-lang#142150
r? bootstrap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cfg(bootstrap) should not be allowed in library/
5 participants